Skip to content

Added a Vortex-only deploy step that checks out the head commit and deploys nothing on fork PRs. - #3310

Merged
AlexSkrypnyk merged 3 commits into
mainfrom
feature/skip-fork-deploy
Nov 11, 2026
Merged

AlexSkrypnyk merged 3 commits into
mainfrom
feature/skip-fork-deploy

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • For fork pull requests in the VORTEX_DEV environment, the deployment branch now uses the pull request’s head revision, and deployment types are disabled for that run. This change applies only to those fork pull request runs; the summary does not describe changes to deployment handling for other runs.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The deploy job adds a VORTEX_DEV-only step for fork pull requests. The step sets DEPLOY_BRANCH to the pull request head SHA and sets VORTEX_DEPLOY_TYPES to none.

Changes: Fork pull-request deployment settings

Layer / File(s) Summary
Fork pull-request environment settings
.github/workflows/build-test-deploy.yml
For fork pull requests, a VORTEX_DEV-only step sets DEPLOY_BRANCH to the head SHA and VORTEX_DEPLOY_TYPES to none.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: Minimal · up to 4769b

Fork pull requests in Vortex's own CI now skip deployment, as intended. Forks of Vortex that configure their own deployment target and open pull requests between their own branches may also skip deployment, which is a narrow edge case and not a merge blocker.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: a Vortex-only deploy step checks out the fork pull request head commit and performs no deployment.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3c06090 and 4769bf7.

Files selected for processing: 1

  • .github/workflows/build-test-deploy.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6af443e4e522325849f98152--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

1 similar comment
@AlexSkrypnyk

This comment has been minimized.

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.50%. Comparing base (b3b1060) to head (4769bf7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3310   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files         116      116           
  Lines        5240     5240           
  Branches       49       49           
=======================================
  Hits         4847     4847           
  Misses        393      393           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

… checks out the head commit and deploys nothing on fork PRs.
@AlexSkrypnyk AlexSkrypnyk changed the title Skipped the deploy job for fork PRs in Vortex's own CI. Added a Vortex-only deploy step that checks out the head commit and deploys nothing on fork PRs. Nov 11, 2026
@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

1 similar comment
@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk
AlexSkrypnyk merged commit d08914c into main Nov 11, 2026
48 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/skip-fork-deploy branch November 11, 2026 11:04
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A1 Board worker 1

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant